fix(ext/node): remove extra properties from node:fs exports#32670
Merged
bartlomieju merged 2 commits intomainfrom Mar 13, 2026
Merged
fix(ext/node): remove extra properties from node:fs exports#32670bartlomieju merged 2 commits intomainfrom
bartlomieju merged 2 commits intomainfrom
Conversation
Remove properties from node:fs default and named exports that Node.js does not export: - 18 flag constants (F_OK, R_OK, W_OK, X_OK, O_*) that should only be available via fs.constants - watchPromise, readFilePromise, readlinkPromise internal helpers - statPromise, realpathPromise, statfsPromise (duplicated in promises.ts) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
F_OK,R_OK,W_OK,X_OK,O_RDONLY,O_WRONLY, etc.) fromnode:fsdefault and named exports — Node.js onlyexposes these via
fs.constants, not as top-level propertieswatchPromise,readFilePromise,readlinkPromise) from the default export objectstatPromise,realpathPromise,statfsPromisefrom named exports(already defined locally in
promises.ts)After this change,
Object.keys(require("node:fs"))in Deno matches Node.jsexcept for 4 not-yet-implemented features (
FileReadStream,FileWriteStream,Utf8Stream,mkdtempDisposableSync).Test plan
cargo build --bin denopassesdeno lint ext/node/polyfills/fs.tspasses🤖 Generated with Claude Code